Don't misinterpret colors as dates #559
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #388
Closes #692
This caught me again recently.
Excel number formats support colours for, e.g. negative values
0.00;0.00[Red]
. Currently thed
inRed
(and some letters of other colours) is confused with thed
in a date formatdd/mm/yyyy
, so the cell is incorrectly treated as adate
cell.The tests force a warning if this happens, by explicitly setting
col_type = "numeric"
.The 'lowercase' variant of the test spreadsheet uses
red
(and similar) rather thanRed
, because this is allowed by the spec, though Excel itself doesn't create such files.