Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Thoth Search UI URL to response headers #1722

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Add Thoth Search UI URL to response headers #1722

merged 2 commits into from
Mar 23, 2022

Conversation

mayaCostantini
Copy link
Contributor

Related Issues and Dependencies

Related to #1721

This introduces a breaking change

  • No

This should yield a new module release

  • Yes

This Pull Request implements

Add Thoth Search UI URL to response headers in schema specification and user-api entrypoint.

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 21, 2022
fridex
fridex approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm! 💯 👍🏻

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2022
@mayaCostantini mayaCostantini mentioned this pull request Mar 21, 2022
Merged
@mayaCostantini
Copy link
Contributor Author

/test build-check

@sesheta
Copy link
Member

sesheta commented Mar 22, 2022

@mayaCostantini: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pre-commit

Use /test all to run all jobs.

In response to this:

/test build-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mayaCostantini
Copy link
Contributor Author

/test all

@goern
Copy link
Member

goern commented Mar 22, 2022

uuuh I like!! ❤️

/approve

@sesheta
Copy link
Member

sesheta commented Mar 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex, goern

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fridex
Copy link
Contributor

fridex commented Mar 22, 2022

/retest

@mayaCostantini
Copy link
Contributor Author

/test all

@harshad16
Copy link
Member

/retest

@harshad16
Copy link
Member

webhooks are degraded: https://www.githubstatus.com/
CI isnt getting the webhook to get triggered

@sesheta sesheta merged commit d65fe42 into thoth-station:master Mar 23, 2022
@mayaCostantini mayaCostantini deleted the add-thoth-search-url-headers branch March 23, 2022 16:45
@harshad16 harshad16 mentioned this pull request Mar 28, 2022
Closed
@mayaCostantini mayaCostantini mentioned this pull request Jun 7, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridex fridex fridex approved these changes

@harshad16 harshad16 Awaiting requested review from harshad16

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mayaCostantini @sesheta @goern @fridex @harshad16