Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate information about Thoth Search UI #1721

Closed
2 tasks done
fridex opened this issue Mar 17, 2022 · 2 comments
Closed
2 tasks done

Propagate information about Thoth Search UI #1721

fridex opened this issue Mar 17, 2022 · 2 comments
Assignees
@mayaCostantini
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fridex
Copy link
Contributor

fridex commented Mar 17, 2022 •
edited by mayaCostantini
Loading

Is your feature request related to a problem? Please describe.

As a consumer of Thoth endpoints, I would like to know where Thoth Search UI is present so that I can browse results. To support this, we could expose information about Thoth Search UI URL in the User API responses.

Describe the solution you'd like

  • supply URL to Thoth Search UI to User API in deployments from configmap via environment variables
  • add URL to Thoth Search UI to response headers

Related: thoth-station/thamos#1080

Describe alternatives you've considered

Have an endpoint that exposes this information, but that might be too redundant. Thamos CLI can check Search UI URL in the API autodiscovery, which will save some traffic.
@fridex fridex added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 17, 2022
This was referenced Mar 21, 2022
Merged
Merged
@codificat
Copy link
Member

based on activivity:
/triage accepted
/lifecycle active
/assign @mayaCostantini
/priority important-soon

@sesheta sesheta added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 22, 2022
@codificat codificat mentioned this issue Jun 2, 2022
Closed
2 tasks
@mayaCostantini
Copy link
Contributor

Closed by thoth-station/thoth-application#2454 and #1722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayaCostantini mayaCostantini

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@codificat @fridex @sesheta @mayaCostantini