Fix the URL path when pointing to the search Web UI

[codificat]

Related Issues and Dependencies

Fixes: thoth-station/support#219

This introduces a breaking change

• No

This should yield a new module release

• Yes (if a patch release is desired, although this is a minor bugfix)

This Pull Request implements

Fix the URL that points to the Thoth Search web UI.

Description

The correct path is /search/advise/:id:, e.g. https://thoth-station.ninja/search/advise/adviser-220520135456-693dce14c5adfe00/summary

Also, this PR includes an update to the pre-commit configuration, and related changes that pre-commit reported during a local run.

[fridex]

lgtm, thanks! 💯 Nice catch! 👍🏻

[sesheta]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fridex]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codificat]

There are a bunch of mypy complaints in the pre-commit checks. These are unrelated to this PR and I believe recent PRs have been overriding these checks.

Should I update the pre-commit configuration to comment out the mypy checks for the time being?

[codificat]

/retest-required

[harshad16]

/test-all

[codificat]

/retest-required

[sesheta]

@codificat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
aicoe-ci/prow/pre-commit	0e0e415	link	true	/test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[codificat]

The failing test is the mypy check and it is unrelated to the changes proposed here.

Looking at recent history in the repo, I see that other PRs have been merged with failing mypy tests, so I assume this is an outstanding item to fix (not sure how much #2173 is related)

Meanwhile though, and based on the above, I believe this one could go in...

What do you think @fridex / @harshad16 ?

[fridex]

Yes, I think this can go in 👍🏻

Regardning failing mypy tests - do we use a new mypy version? I noticed tests started failing at some point without any source code changes.

[codificat]

Regardning failing mypy tests - do we use a new mypy version? I noticed tests started failing at some point without any source code changes.

pre-commit plugins were updated at the end of March, including a change in mypy from v0.770 to v0.942 (0726c6f#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9L39

As this PR is taking the opportunity to further update pre-commit config, let me quickly try to revert that particular mypy version change...

[codificat]

As this PR is taking the opportunity to further update pre-commit config, let me quickly try to revert that particular mypy version change...

Unfortunately, I just get different mypy errors when checking with v0.770, all of them on thoth/adviser/unit.py, which has not changed since the updated mypy... so, I really don't get what's going on here.

Probably worth creating a separate issue about mypy fixes though, and just merging that one in? (I don't have write perms to do that, though)

[mayaCostantini]

Merging as pre-commit is failing because of known issues with mypy.