Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the URL that points to an advise's results gives a 404 #219

Closed
codificat opened this issue May 20, 2022 · 5 comments · Fixed by thoth-station/adviser#2341
Closed

the URL that points to an advise's results gives a 404 #219

codificat opened this issue May 20, 2022 · 5 comments · Fixed by thoth-station/adviser#2341
Assignees
@codificat
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@codificat
Copy link
Member

codificat commented May 20, 2022 •
edited
Loading

Describe the bug

When I ask for an advise, one of the info items I get is a URL to explore the results on the website.

However, accessing that URL results on an HTTP 404 (not found).

To Reproduce

Steps to reproduce the behavior:

  1. Run thamos advise
  2. Look at the results
  3. Find a line like this:
Link Message
https://thoth-station.ninja/search/adviser-220520135456-693dce14c5adfe00/summary Results can be browsed in Thoth search

Expected behavior

The link should work

Additional context

The correct URL path seems to be /search/advise/:id: (i.e. add /advise/)
@sesheta sesheta added needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. needs-sig labels May 20, 2022
@codificat
Copy link
Member Author

/sig user-experience
/triage accepted
/priority important-soon
/kind bug

@sesheta sesheta added sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/bug Categorizes issue or PR as related to a bug. and removed needs-sig needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. labels May 20, 2022
@codificat codificat mentioned this issue May 20, 2022
Merged
@goern
Copy link
Member

goern commented May 24, 2022

/assign @Gkrumbach07
/priority critical-urgent
/remove-priority important-soon

@Gkrumbach07
Copy link
Member

Gkrumbach07 commented May 24, 2022 •
edited
Loading

That is a broken link.

Link is missing the /advise/.

Working link is https://thoth-station.ninja/search/advise/adviser-220520135456-693dce14c5adfe00/summary

There just needs to be a change in the justification.

@codificat
Copy link
Member Author

Sorry, I forgot to
/assign
myself. Note that there is a PR to fix this already linked: thoth-station/adviser#2341
/unassign @Gkrumbach07
/lifecycle active

@codificat
Copy link
Member Author

/assign
/unassign @Gkrumbach07
/lifecycle active

@sesheta sesheta added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label May 26, 2022
@codificat codificat mentioned this issue Jun 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codificat codificat

Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the URL path when pointing to the search Web UI codificat/adviser
4 participants
@goern @codificat @Gkrumbach07 @sesheta