Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added yml config for Green Metrics Tool #587

Conversation

jcamilleri-scottlogic
Copy link
Collaborator

associated test.

@jcamilleri-scottlogic jcamilleri-scottlogic marked this pull request as draft May 10, 2024 11:14
@jcamilleri-scottlogic jcamilleri-scottlogic marked this pull request as ready for review May 10, 2024 11:15
@jcamilleri-scottlogic jcamilleri-scottlogic marked this pull request as draft May 10, 2024 11:16
@mrchrisadams
Copy link
Member

Thanks for this @jcamilleri-scottlogic - as discussed, I'll add the necessary changes to run the django container in the setup

@mrchrisadams mrchrisadams changed the title Added yml config for Green Metrics Tool and Added yml config for Green Metrics Tool May 15, 2024
@mrchrisadams
Copy link
Member

ok, once #588 is merged in I think we'll be in shape to update the usage scenarios for testing in GMT:

Some feedback from Arne at Green Coding Solutions:

I have given the PR a quick look and the usage_scenario file. A few things I saw:

  • flow is not correctly indented. Must be at root level
  • depends_on is no dict. must be list
  • There is no Dockerfile to build the 'mariadb' service
    ...

Since it is in Draft I assume that is expected. I just wanted to quickly try and this is what I encountered.

@jcamilleri-scottlogic - I'll make the commits to this branch as I work to get the usage scenarios generating useable numbers.

@mrchrisadams
Copy link
Member

@jcamilleri-scottlogic - I don't think I can make commits to this branch, so I've made a new PR, pulling in your commit, so that you folks are recognised for working on the PR:

#589

I've also added you as a collaborator for the time being, so you are able to make pushes to that PR/branch if need be.

@jcamilleri-scottlogic
Copy link
Collaborator Author

jcamilleri-scottlogic commented May 15, 2024 via email

@mrchrisadams
Copy link
Member

@jcamilleri-scottlogic - I'm making notes as I work in #589 - it might be worth comparing notes there

@mrchrisadams
Copy link
Member

I'm closing this in favour of the other PR #589 where @jcamilleri-scottlogic continued to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants