Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order button showing when order-column is set to empty string #5003

Merged
merged 2 commits into from
Jan 28, 2021

Conversation

emptynick
Copy link
Collaborator

@emptynick emptynick commented Jul 6, 2020

When the ConvertEmptyStringsToNull middleware is disabled, BREAD order-column will be stored as an empty string instead of null, thus the order button will be shown.

Fixes #4930

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #5003 (aec7a57) into 1.4 (ccaf7e8) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.4    #5003   +/-   ##
=========================================
  Coverage     63.31%   63.31%           
  Complexity     1379     1379           
=========================================
  Files           194      194           
  Lines          4075     4075           
=========================================
  Hits           2580     2580           
  Misses         1495     1495           
Impacted Files Coverage Δ Complexity Δ
src/Http/Controllers/VoyagerBaseController.php 57.69% <0.00%> (ø) 143.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccaf7e8...aec7a57. Read the comment docs.

@emptynick emptynick merged commit b93e322 into 1.4 Jan 28, 2021
@emptynick emptynick deleted the order-button-fix branch January 28, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order button persist even if Order display column is set to -- None --
1 participant