-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order button persist even if Order display column is set to -- None -- #4930
Comments
You need to change |
As far as I saw in browse view
Both have to be set to show the button. In my case, only 1 is set to order the query result shown in the page. |
Yes, they are both used, should work with both and actually work for me. This is what's saved in db if I change Display Column to None: {"order_column":"title","order_display_column":null,"order_direction":"asc","default_search_key":null,"scope":null} I see also scope is saved as empty string in your screenshot, did you disable P.S. |
Yeap, I think thats why it is saving "", but anyway is
:) I'm using it in the same way. |
Empty string means variable is set as empty string.
You could use ConvertEmptyStringsToNull only in that route. |
Ok, thank you I will try it. |
We could just use |
This issue has been automatically locked since there has not been any recent activity after it was closed. If you have further questions please ask in our Slack group. |
Version information
Description
When I update Order display column in my bread settings and I set it to
-- None --
then Order button still shows. Seems bread does update"order_display_column":""
and it excepts"order_display_column":null
to not show Order button. If I change""
tonull
in MySQL then button disappears.Steps To Reproduce
Steps to reproduce the behavior:
Expected behavior
Order button should not be shown.
Screenshots
Bread browse view:
![image](https://user-images.githubusercontent.com/26321350/81597773-8c027380-93c6-11ea-9bf6-8a35360bb0f9.png)
DB settings:
![image](https://user-images.githubusercontent.com/26321350/81597869-afc5b980-93c6-11ea-931c-3f79bd1237e8.png)
The text was updated successfully, but these errors were encountered: