Allow web's SafeAreaView to forward ref to its underlying view #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janicduplessis
requested changes
Apr 28, 2023
antoine-cottineau
force-pushed
the
feat/add-forwardRef-safe-area-view-web
branch
from
1930497
to
10a0c32
Compare
|
It should be good now 🙂 |
jacobp100
approved these changes
Apr 28, 2023
janicduplessis
approved these changes
Apr 29, 2023
|
My pleasure 🙂 |
|
@janicduplessis Thank you fast release! Am I missing something or they are just lost on their way to production? |
|
I might have messed something up, I published 4.5.3 which seems fine. Thanks for finding this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR solves the issue #295 by adding the ability for the web's
SafeAreaViewto forward the ref to the underlyingView.Test Plan
I run the code by creating a basic Expo app and patching it with my changes.