Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forwardRef to SafeAreaView.web.tsx #295

Closed
paulpopiel opened this issue Jul 7, 2022 · 2 comments
Closed

Add forwardRef to SafeAreaView.web.tsx #295

paulpopiel opened this issue Jul 7, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Platform: Web

Comments

@paulpopiel
Copy link

paulpopiel commented Jul 7, 2022 •
edited

react-native-safe-area-context/src/SafeAreaView.web.tsx

Line 22 in ccce005

export function SafeAreaView({

Web version of SafeAreaView is missing a forwardRef passing the ref to the underlying returned View.

e.g. similar to mobile version:

react-native-safe-area-context/src/SafeAreaView.tsx

Line 9 in d14de35

export const SafeAreaView = React.forwardRef<

@jacobp100
Copy link
Collaborator

Would you be willing to submit a PR?

@jacobp100 jacobp100 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers Platform: Web labels Jan 19, 2023
@antoine-cottineau antoine-cottineau mentioned this issue Apr 28, 2023
Merged
@antoine-cottineau
Copy link
Contributor

Should we close this? I think my PR has implemented what was expected 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Platform: Web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@janicduplessis @jacobp100 @paulpopiel @antoine-cottineau