Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper ssh key file modes and callback usage #154

Merged
merged 2 commits into from
Jun 13, 2015
Merged

Conversation

johnnyman727
Copy link
Contributor

This tiny PR does three things:

  1. Creates both SSH keys with a 0600 file mode
  2. Adds a log that the key generate function worked (if it did)
  3. Properly executes callbacks in the key generation function (which was preventing 2 from working)
  4. Changes the setupLocal function to call callbacks with function(err) where 'Keys already existcan be an error instead offunction(err, createdBool)`. This method is more consistent with Node.

@johnnyman727
Copy link
Contributor Author

@Frijol can you give this a quick review?

@Frijol
Copy link
Member

Frijol commented Jun 13, 2015

lgtm

johnnyman727 added a commit that referenced this pull request Jun 13, 2015
Proper ssh key file modes and callback usage
@johnnyman727 johnnyman727 merged commit 00ef153 into master Jun 13, 2015
@johnnyman727 johnnyman727 deleted the jon-fix-keys branch June 13, 2015 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants