Use common err paradigm instead of two args for key generation

tessel · Jun 13, 2015 · 01b7d4d · 01b7d4d
1 parent ac90f9d
commit 01b7d4d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/lib/key.js b/lib/key.js
@@ -3,9 +3,9 @@ var provision = require('./tessel/provision'),
 
 module.exports = function() {
   return new Promise(function(resolve, reject) {
-    provision.setupLocal(function(err, created) {
-      if (!created) {
-        reject(new Error('Key already exists. No new key created.'));
+    provision.setupLocal(function(err) {
+      if (err) {
+        reject(err);
       } else {
         resolve();
       }

diff --git a/lib/tessel/provision.js b/lib/tessel/provision.js
@@ -15,9 +15,14 @@ Tessel.prototype.provisionTessel = function() {
   var self = this;
   if (self.connection.connectionType === 'USB') {
     // Check if local .tessel file has keypair, if not, put it there
-    setupLocal(function() {
-      // Authorize Tessel for SSH
-      authTessel(self);
+    setupLocal(function(err) {
+      if (err) {
+        logs.err(err);
+        return;
+      } else {
+        // Authorize Tessel for SSH
+        authTessel(self);
+      }
     });
   } else {
     logs.warn('Tessel must be connected with USB to use this command.');
@@ -75,15 +80,15 @@ function setupLocal(callback) {
               return;
             } else {
               if (typeof callback === 'function') {
-                callback(null, true);
+                callback();
               }
             }
           });
       });
     });
   } else {
     if (typeof callback === 'function') {
-      callback(null, false);
+      callback(new Error('Keys already exist. Refusing to overwrite them.'));
     }
   }
 }