fix: Update to follow change in db_instance id #499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws_db_instance was updated by hashicorp/terraform-provider-aws#31232 such that the `id` attribute now tracks the resource ID, and the identifier is now returned in a new attribute named `identifier`. The resource ID is already available in `instance_resource_id`. This fix allows existing users to continue using this module with no changes and preserves the original function of the `id` attribute in this module. Fixes terraform-aws-modules#495.
jwoytek
changed the title
jwoytek
changed the title
3 tasks
|
This issue has been resolved in version 6.0.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A breaking change in the AWS provider changed the output of the upstream
idattribute. Update theidmodule output to return the RDS DB instance identifier. This is an alternate solution to the one proposed in #495.Motivation and Context
db_instancewas updated by hashicorp/terraform-provider-aws#31232 such that theidattribute now tracks the resource ID, and the identifier is now returned in a new attribute namedidentifier.The resource ID is already available in
instance_resource_id. This fix allows existing users to continue using this module with no changes and preserves the original function of theidattribute in this module.Fixes the base issue reported in #495.
Breaking Changes
This should not represent a breaking change, as the referenced
identifierattribute hasexisted in
db_instancesince 2.33, which is well earlier than the current requirements forthis module.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request