feat!: Replace random password generation with manage master password, min AWS provider version increased to 5.0, id output replaced with identifier

[decayofmind]

Description

• Replace random password generation with new RDS manage master user password which is now enabled by default
• Increase AWS provider minimum supported version to 5.0
• Replace id output for DB instance to identifier (ref: rds/instance: NEW ID configuration hashicorp/terraform-provider-aws#31232)
• Password outputs have been removed

Motivation and Context

Support of this new feature allows users to offload master password lifecycle completely to AWS, including rotation and avoid storing credentials in state file.

• Resolves Support for storing master user password in Secrets Manager #488
• Resolves Update variables.tf #494
• Resolves add identifier to outputs #495
• Resolves feat: Add identifier output #496
• Resolves db_instance_id is returning the DB Resource ID #498
• Resolves fix: Update to follow change in db_instance id #499

Breaking Changes

• Yes

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects
• I have executed pre-commit run -a on my pull request

[bryantbiggs]

similar to what we did with the Aurora module, we'll want to remove the random password generation here terraform-aws-modules/terraform-aws-rds-aurora#335

This will be a breaking change but its the proper solution for keeping secrets secure, out of Terraform state, and allow them to more easily be rotated without Terraform interference

[asinghggt]

any update on this?

[github-actions]

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

[rlmartin]

Any updates on this?

[antonbabenko]

This PR is included in version 6.0.0 🎉

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.