-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce test suite time #656
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks! Ideally we have no sleeps in tests, but even this is a big win. Any flakiness concern on sleeping exactly the amount of the refresh impl? Should we sleep 2s to be sure or reduce the refresh interval (maybe only for this test)?
Changing refresh rate to milliseconds takes another second off of the test, having a buffer of 5 millisecond sleep seems to be good, no issues after running test locally 80 times |
Can you confirm with server any harm in changing this to 100ms just for our tests? Meaning, is this max expiry before refetch or is this some kind of loop interval. If no prob, lets do that. |
YX confirmed this is fine, only side effect is more DB IO Jotting down an observation, setting refresh rate to 1 ms causes some tests to fail due to max QPS being reached, but 100 ms seems fine. |
Nice. |
What was changed
Set cluster cache refresh rate to seconds instead of minutes. Now our test doesn't need to wait 60+ seconds for the cache to refresh
TestOperator_Cluster_Operations
goes from ~118.29 seconds to ~4.4 secondsOverall CI runtime goes from 10m32s to 7m26s (sample size 1)
Why?
Speed up tests
Checklist
Ran test locally