Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Reduce test suite time #645

Closed
cretz opened this issue Aug 23, 2024 · 0 comments · Fixed by #656
Closed

[Feature Request] Reduce test suite time #645

cretz opened this issue Aug 23, 2024 · 0 comments · Fixed by #656
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Aug 23, 2024 •
edited
Loading

Describe the solution you'd like

Currently tests take 2m+ but they should only take a few seconds. I think there is a 90s sleep in there we should remove, but there may be other sleeps we should remove. We should try to be reactive to results instead of 1s+ sleeping (even if that means high-frequency polling). We can redesign tests or even reduce the strictness of our assertions if we must (hopefully not).
@cretz cretz added the enhancement New feature or request label Aug 23, 2024
@yuandrew yuandrew mentioned this issue Sep 5, 2024
Merged
yuandrew added a commit that referenced this issue Sep 5, 2024
@yuandrew
Reduce test suite time (#656)
9a7224d 
## What was changed
<!-- Describe what has changed in this PR -->
Set cluster cache refresh rate to seconds instead of minutes. Now our
test doesn't need to wait 60+ seconds for the cache to refresh

`TestOperator_Cluster_Operations` goes from ~118.29 seconds to ~4.4
seconds
Overall CI runtime goes from 10m32s to 7m26s (sample size 1)

## Why?
<!-- Tell your future self why have you made these changes -->
Speed up tests

## Checklist
<!--- add/delete as needed --->

1. Closes #645
2. How was this tested:
<!--- Please describe how you tested your changes/how we can test them
-->
Ran test locally

3. Any docs updates needed?
<!--- update README if applicable
      or point out where to update docs.temporal.io -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce test suite time yuandrew/cli
1 participant
@cretz