Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow insecure CSRF cookies #515

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

josh-berry
Copy link
Collaborator

This forward-ports #408 to the cli-rewrite branch.

This forward-ports #408 to the cli-rewrite branch.
@josh-berry josh-berry requested a review from cretz April 1, 2024 18:14
@josh-berry
Copy link
Collaborator Author

hm... this failed only on Windows but I don't understand why yet. The failures make it look like something very basic is broken (passing the wrong flags etc) that I don't think is related to this change. Will look into this before merging of course.

@cretz
Copy link
Member

cretz commented Apr 1, 2024

Looks like a test flake on TestSharedServerSuite/TestActivity_Complete. Probably just need to up that timeout from 5s to 10s. Not related to anything in this PR surely.

@josh-berry josh-berry merged commit cb1d5b4 into cli-rewrite Apr 2, 2024
6 checks passed
@josh-berry josh-berry deleted the josh/fwdport-408-insecure-csrf branch April 2, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants