Insecure CSRF cookie #408
Merged
Insecure CSRF cookie #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-berry
approved these changes
Jan 12, 2024
|
Thanks for the PR! |
josh-berry
added a commit
that referenced
this pull request
Apr 1, 2024
This forward-ports #408 to the cli-rewrite branch.
josh-berry
added a commit
that referenced
this pull request
Apr 2, 2024
This forward-ports #408 to the cli-rewrite branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
CSRF cookie is now set without
Secureattribute.Why?
Now CSRF cookie is
Securebut development servers are usually used locally without HTTPS. For some reason, it works fine in Chrome (there is an exception forlocalhostdomain inSecurehandling) but does not work in Safari.Since
start-devcommand starts a development server, I think it is safe to use insecure cookies here.Checklist
Closes
How was this tested:
Checked locally with different browsers.
No.