Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused "TAG" private field. #9

Closed
cwang20231 opened this issue Feb 16, 2024 · 1 comment · Fixed by #10
Closed

Remove unused "TAG" private field. #9

cwang20231 opened this issue Feb 16, 2024 · 1 comment · Fixed by #10
Assignees
@cwang20231
Labels
Group 09 Group_9_SCM_Project Technical Debt

Comments

@cwang20231
Copy link
Collaborator

cwang20231 commented Feb 16, 2024 •
edited
Loading

Description of the Technical Debt:
String variable TAG was created but not used.

image

image

Why is this an issue?
If a private field is declared but not used in the program, it can be considered dead code and should therefore be removed. This will improve maintainability because developers will not wonder what the variable is used for.

Proposed solution:
Remove the private variable TAG
image

Technical information

  • Device: [e.g. Nexus 7 (2013)]
  • OS: [e.g. LineageOS 15.1]
  • OpenTracks version: [e.g. v3.2.4]
  • OpenTracks commit id (only for nightly builds): [e.g. 4b333bb]
@cwang20231 cwang20231 self-assigned this Feb 16, 2024
@cwang20231 cwang20231 linked a pull request Feb 16, 2024 that will close this issue
Commiting my changes of the method #10
Merged
@cwang20231
Copy link
Collaborator Author

The issue has been solved and the merge accepted.

@Sharanyu Sharanyu added Group 09 Group_9_SCM_Project Technical Debt labels Feb 17, 2024
@Sharanyu Sharanyu mentioned this issue Feb 17, 2024
Merged
Sharanyu added a commit to rilling/OpenTracks-Winter-SOEN-6431_2024 that referenced this issue Feb 17, 2024
@Sharanyu
Fix: Group9 issues: #1 #2 #6 #9 #11 #13 #14 #15 (#50)
35390eb 
This PR consists of changes for issues resolved by Group9.


[#1](tarekFerdous#1)
Define a constant instead of duplicating this literal "<open>1</open>" 3
times.

[#2](tarekFerdous#2)
Replace this usage of 'Stream.collect(Collectors.toList())' with
'Stream.toList()' Group 09

[#6](tarekFerdous#6)
Either re-interrupt this method or rethrow the "InterruptedException"
that can be caught here.

[#9](tarekFerdous#9)
Remove unused "TAG" private field.

[#11](tarekFerdous#11)
Use isEmpty() to check whether the collection is empty or not.

[#13](tarekFerdous#13)
Fixing technical debts for io/file/impoter/importService.java and
io/file/importer/importViewModel.java

[#14](tarekFerdous#14)
io/file/importer/KmlTrackImporter and io/file/importer/KmzTrackImporter

[#15](tarekFerdous#15)
Removing the Deprecated lines in the code Group(09)
beingtranquil pushed a commit that referenced this issue Mar 17, 2024
@Sriluharshini
Merge pull request #12 from SonamChugh13/HarshiniBandaru
c0549f8 
Refactoring the Variable Name to Standard Naming Practices - Issue #9
beingtranquil pushed a commit that referenced this issue Mar 17, 2024
@JSM2512
Merge pull request #9 from JSM2512/mkjodhani/5-codestyle-issues-in-ch…
43804f4 
…artviewjava

fixed the code-style issues
beingtranquil pushed a commit that referenced this issue Mar 17, 2024
@rextivlan
Fix issue #9 to improve Reliability and remove Technical Debt
577b0ea
beingtranquil pushed a commit that referenced this issue Mar 17, 2024
@rextivlan
Fix issue #9 to improve Reliability and remove Technical Debt
87a44d6
beingtranquil pushed a commit that referenced this issue Mar 17, 2024
@rextivlan
Merge pull request #10 from rextivlan/dev_ali
5cbc2b6 
Fix issue #9 to improve Reliability and remove Technical Debt
beingtranquil pushed a commit that referenced this issue Mar 17, 2024
@rextivlan
Revert changes for Issue #9
b6e7dfe
beingtranquil pushed a commit that referenced this issue Mar 17, 2024
@SraddhaBhattacharjee
#9 Renamed record method
7cd5cb2 
Renamed record method to create
beingtranquil pushed a commit that referenced this issue Mar 17, 2024
@OmniaAlam
Merge pull request rilling#22 from OmniaAlam/9-rename-this-method-to-…
fc1c45e 
…not-match-a-restricted-identifier

#9 Renamed record method
beingtranquil pushed a commit that referenced this issue Mar 17, 2024
@racCC
Merge pull request #9 from Reva-B98/main_rac
7342fc2 
Issue#2 Refactored the public class to protected class
beingtranquil pushed a commit that referenced this issue Apr 9, 2024
@HWJFish
Merge pull request #9 from HWJFish/116-settings-voice-announce-for-to…
5e928e1 
…tal-time-skied-at-End-of-the-recording

116 settings voice announce for total time skied at end of the recording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwang20231 cwang20231

Labels
Group 09 Group_9_SCM_Project Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Commiting my changes of the method tarekFerdous/OpenTracks-Winter-SOEN-6431_2024_G9
2 participants
@Sharanyu @cwang20231