Use of isEmpty() for issue #11 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use isEmpty() to check whether the collection is empty or not. Deliverables Solved!
beingtranquil
pushed a commit
that referenced
this pull request
Mar 17, 2024
Refactoring the Variable Name to Standard Naming Practices - Issue #9
beingtranquil
pushed a commit
that referenced
this pull request
Mar 17, 2024
fixing onDisconnect method
beingtranquil
pushed a commit
that referenced
this pull request
Mar 17, 2024
Define and throw a dedicated exception instead of using a generic one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use isEmpty() to check whether the collection is empty or not. Deliverables Solved!
Proposed Solution:
Use of isEmpty() directly conveys the intent of checking whether the collection has elements or not, making the code more concise and easier to understand. This practice aligns with Java best practices and enhances code readability, maintainability, and clarity for developers who review or modify the codebase.
Changes Made:
Impact:
This issue aims to improve code quality and readability by applying this simple but effective improvement throughout the relevant codebase.
Link to the the issue
#11 (comment)
License agreement
By opening this pull request, you are providing your contribution under the Apache License 2.0 (see LICENSE.md).
Note: new dependencies/libraries
Please refrain from introducing new libraries without consulting the team.