Fix issue #9 to improve Reliability and remove Technical Debt

tarekFerdous · Feb 14, 2024 · 87a44d6 · 87a44d6
1 parent 9785972
commit 87a44d6
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/main/java/de/dennisguse/opentracks/data/CustomContentProvider.java b/src/main/java/de/dennisguse/opentracks/data/CustomContentProvider.java
@@ -122,15 +122,14 @@ public boolean onCreate() {
      */
     @VisibleForTesting
     boolean onCreate(Context context) {
-        CustomSQLiteOpenHelper databaseHelper = new CustomSQLiteOpenHelper(context);
-        try {
+        try (CustomSQLiteOpenHelper databaseHelper = new CustomSQLiteOpenHelper(context)) {
             db = databaseHelper.getWritableDatabase();
             // Necessary to enable cascade deletion from Track to TrackPoints and Markers
             db.setForeignKeyConstraintsEnabled(true);
-        } catch (SQLiteException e) {
+          } catch (SQLiteException e) {
             Log.e(TAG, "Unable to open database for writing.", e);
-        }
-        return db != null;
+          }
+          return db != null;
     }
 
     @Override