Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve at error detection #133

Merged
merged 1 commit into from
Jan 19, 2015
Merged

Improve at error detection #133

merged 1 commit into from
Jan 19, 2015

Commits on Jan 17, 2015

  1. Improve at error detection

     - Improve performance by only computing stack if its not ok.
     - Fix bug where stack pretty printers prepend stuff to the
        stack. i.e. we now allows ^[^\s]*\s* instead of ^\s*
     - Fix edgecase stack line is `[Object object].method`.
        We now test s[1], s[2] and s[3] to work around this.
    
    This improves the detection of `at` and makes it more likely
        to be correct.
    
    This is a very important feature as it's the only thing that
        makes debugging failed assertions easy.
    
    Not fixing this causes some assertions to just not print an
        `at` statement at all.
    
    cc @substack
    Raynos committed Jan 17, 2015
    Configuration menu
    Copy the full SHA
    4ed7caf View commit details
    Browse the repository at this point in the history