Improve at error detection #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve performance by only computing stack if its not ok.
- Fix bug where stack pretty printers prepend stuff to the
stack. i.e. we now allows ^[^\s]*\s* instead of ^\s*
- Fix edgecase stack line is `[Object object].method`.
We now test s[1], s[2] and s[3] to work around this.
This improves the detection of `at` and makes it more likely
to be correct.
This is a very important feature as it's the only thing that
makes debugging failed assertions easy.
Not fixing this causes some assertions to just not print an
`at` statement at all.
cc @substack
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stack. i.e. we now allows ^[^\s]\s instead of ^\s*
[Object object].method.We now test s[1], s[2] and s[3] to work around this.
This improves the detection of
atand makes it more likelyto be correct.
This is a very important feature as it's the only thing that
makes debugging failed assertions easy.
Not fixing this causes some assertions to just not print an
atstatement at all.cc @substack