Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New user defined modes automatically contain mode switching commands in contradiction to the talon wiki #1437

Closed
maxbruening opened this issue May 16, 2024 · 2 comments · Fixed by #1515
Assignees

Comments

@maxbruening
Copy link
Contributor

maxbruening commented May 16, 2024

When a user defines a new mode, this mode automatically contains mode switching commands like "command mode" or "sleep all". This is due to the headers of the files modes_not_dragon.talon and modes.talon.

According to the talon wiki this behaviour runs against the primary purpose of a new user defined mode: "So why might you add a custom mode? The main reason is because you want to disable all normal voice commands so only the ones in your mode are active. An example might be where you were using a full screen computer game, and wanted to eliminate potential conflicts with commands outside the game context."

So I guess either the wiki or community should change.

Personally, I think community should change. I stumbled across this because I wanted to have a new empty mode so that I could use different voice software in combination with Talon (i.e. voice from the other software but Talon noises).

@maxbruening
Copy link
Contributor Author

maxbruening commented May 16, 2024

Maybe the mode switching commands should be the first thing to appear in every mode's talon file? This would make things very explicit and be in the spirit of #1122 .

If we want users to receive warnings about already being in a mode (#1327) this would also need to be explicitly defined in every mode's talon file.

I would argue it is not necessary to be able to switch to e.g. command/dictation/sleep mode via pre-defined voice commands when one creates a new mode. If I want that, I need to write it explicitly in the origin mode's talon file.

Drawback: Slightly more lines of code, especially the more modes there are.
Benefit: No unexpected commands in new modes. The wiki encourages users not to have many modes.

@AndreasArvidsson
Copy link
Collaborator

AndreasArvidsson commented Jul 21, 2024

I agree with you. If you make a custom mode that should be empty by default. I think this is something we need to discuss in a, in community session.
@nriley

@AndreasArvidsson AndreasArvidsson self-assigned this Jul 30, 2024
nriley added a commit that referenced this issue Aug 3, 2024
Users should be allowed to make their own custom modes and not had any
existing commands interfere.

This is what a Talon wiki describes.
https://talon.wiki/customization/talon%20framework/modes/

Fixes #1437



We could of course go even more explicit and not even have these
combination files. The sleep command could be in a command mode file and
in the dictation mode file etc.

Note that the dragon files are still enabled in all nodes. I don't know
this engine well enough to make changes and I don't want to break
something.

---------

Co-authored-by: Nicholas Riley <com-github@sabi.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants