Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of mode: all #1122

Closed
pokey opened this issue Feb 26, 2023 · 5 comments
Closed

Remove use of mode: all #1122

pokey opened this issue Feb 26, 2023 · 5 comments

Comments

@pokey
Copy link
Collaborator

pokey commented Feb 26, 2023

Do we want to stop using mode: all? It seems like it could be surprising if a user creates a mode and unexpected commands are active

See also #603
@phillco
Copy link
Collaborator

phillco commented Feb 28, 2023

I'd be fine with removing all the invocations in the repository but leaving the mode itself in case users want to use it in their own forks (it can be handy if you don't plan to make additional modes)

@pokey
Copy link
Collaborator Author

pokey commented Mar 1, 2023

wait, all is a mode? I thought mode: all was a special thing

@rntz
Copy link
Collaborator

rntz commented Mar 4, 2023 •
edited
Loading

all is "sort of" a mode in that it's present in scope.get("mode"). But it's always active and cannot be disabled, so it's not a mode the user can activate/deactivate.

@rntz
Copy link
Collaborator

rntz commented Mar 4, 2023

counterpoint: folks may want go to sleep to be active in all modes.

@nriley
Copy link
Collaborator

nriley commented Apr 29, 2023

We talked about this on the maintenance session today.

  • We were generally in agreement that removing "mode: all" and "not mode" from all files makes sense
  • Andreas felt that it makes sense to have a separate Talon file for each mode
  • We could consider a configurable "what happens when I wake up or sleep Talon" rather than separate commands, then each command implementation would be a single line of TalonScript (e.g., the ones that hide various elements of the knausj help system)
  • Or at the least we should comment the difference between "welcome back" and "Talon wake", etc.

@phillco phillco mentioned this issue Jun 17, 2023
Merged
knausj85 pushed a commit that referenced this issue Oct 29, 2023
@phillco @pre-commit-ci
modes: simplify modes a little bit (#1215)
14fdcd0 
#1122

We want to reduce the use of `mode:all` and instead have files that
specifically target specific modes. This breaks up the existing sleep
files to better capture their semantics and adds some comments.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
BridgeTheMasterBuilder pushed a commit to BridgeTheMasterBuilder/community that referenced this issue Nov 3, 2023
@phillco @pre-commit-ci @BridgeTheMasterBuilder
modes: simplify modes a little bit (talonhub#1215)
2d27558 
talonhub#1122

We want to reduce the use of `mode:all` and instead have files that
specifically target specific modes. This breaks up the existing sleep
files to better capture their semantics and adds some comments.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
rokubop pushed a commit to rokubop/roku_talon that referenced this issue Nov 6, 2023
@phillco @pre-commit-ci @rokubop
modes: simplify modes a little bit (talonhub#1215)
b808ae3 
talonhub#1122

We want to reduce the use of `mode:all` and instead have files that
specifically target specific modes. This breaks up the existing sleep
files to better capture their semantics and adds some comments.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@maxbruening maxbruening mentioned this issue May 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rntz @nriley @phillco @pokey @knausj85