-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit use of modes #603
Comments
related: talonvoice/talon#239 |
@pokey @knausj85
https://github.com/AndreasArvidsson/andreas-talon/blob/master/langs/javascript/typescript.talon |
I have now made a pr to update the programming languages to use tags instead |
- Switch gdb and windbg to tags Addresses the remainder of #603 Probably most relevant to @fidgetingbits --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
- Switch gdb and windbg to tags Addresses the remainder of talonhub#603 Probably most relevant to @fidgetingbits --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
- Switch gdb and windbg to tags Addresses the remainder of talonhub#603 Probably most relevant to @fidgetingbits --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
The problem
We have had issues in the past where commands are unexpectedly active in sleep mode, eg #561. The problem is that if you put
mode:
in a.talon
file header, you disable the implicitmode: command
, which in turn allows you to enable the file during sleep accidentally.A quick search reveals that we still have some commands active in sleep mode for this reason. See eg go.talon, which results in
go
commands being active if talon is sleeping while you have ago
file open.The solution
We may want to prefer using tags in many of the places that we use modes today. For example, the following modes are good candidates to become tags:
user.homophones
user.windbg
user.help
user.help_scope
On the other hand, things like "game" or "solo" would be examples of good, general modes, because a mode should ideally be very transformative of the command set and make sense when enabled by itself.
The text was updated successfully, but these errors were encountered: