Skip to content

Commit

Permalink
Don't use not mode (#1515)
Browse files Browse the repository at this point in the history
Users should be allowed to make their own custom modes and not had any
existing commands interfere.

This is what a Talon wiki describes.
https://talon.wiki/customization/talon%20framework/modes/

Fixes #1437



We could of course go even more explicit and not even have these
combination files. The sleep command could be in a command mode file and
in the dictation mode file etc.

Note that the dragon files are still enabled in all nodes. I don't know
this engine well enough to make changes and I don't want to break
something.

---------

Co-authored-by: Nicholas Riley <com-github@sabi.net>
  • Loading branch information
AndreasArvidsson and nriley authored Aug 3, 2024
1 parent c14c380 commit 7dedbd7
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
1 change: 1 addition & 0 deletions BREAKING_CHANGES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ applied given the delay between changes being submitted and the time they were r
and merged.

---
* 2024-07-31 Remove commands `"command mode"`, `"dictation mode"` from custom user modes. Note that if you have any custom modes where you want these commands you could add that mode to the context of `command_and_dictation_mode.talon` or copying the command to one of your custom files.
* 2024-07-30 Deprecate `lend` and `bend` commands in favor of `go line end | tail` and `go line start | head`.
* 2024-07-28 Removed the following actions in favor of the new action/modifier grammar.
https://github.com/talonhub/community/blob/37a8ebde90c8120a0b52555030988d4f54e65159/core/edit/edit.talon#L3
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
not mode: sleep
mode: command
mode: dictation
-
^dictation mode$:
mode.disable("sleep")
Expand Down
3 changes: 1 addition & 2 deletions core/modes/modes_dragon.talon
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
mode: sleep
not mode: sleep
mode: all
speech.engine: dragon
-
# The optional <phrase> afterwards allows these to match even if you say arbitrary text
Expand Down
3 changes: 2 additions & 1 deletion core/modes/modes_not_dragon.talon
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
mode: command
mode: dictation
mode: sleep
not mode: sleep
not speech.engine: dragon
-
# The optional <phrase> afterwards allows these to match even if you say arbitrary text
Expand Down

0 comments on commit 7dedbd7

Please sign in to comment.