-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to linked video when double click on camera in CamerasTable
#1825
Switch to linked video when double click on camera in CamerasTable
#1825
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## liezl/add-gui-elements-for-sessions #1825 +/- ##
=======================================================================
- Coverage 74.10% 74.09% -0.02%
=======================================================================
Files 135 135
Lines 25314 25323 +9
=======================================================================
+ Hits 18760 18763 +3
- Misses 6554 6560 +6 ☔ View full report in Codecov by Sentry. |
CamerasTable
, we switched to the linked video (if any)CamerasTable
, switch to the linked video (if any)
CamerasTable
, switch to the linked video (if any)CamerasTable
, switch to the linked video (if any)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works! But this logic should not be placed inside GenericTableView
.
…-click-video-table
CamerasTable
, switch to the linked video (if any)CamerasTable
5d120c6
into
liezl/add-gui-elements-for-sessions
Description
When a user double-clicks a row in
CamerasTable
, SLEAP will automatically sets thestate["camera"]
to the selected camera and switch the video to the video that is linked to the selected camera. Added a new callback function inQtVideoPlayer
class so that when a camera is double-clicked, videos are updated accordingly.Types of changes
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️