Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing inference on multiple videos via
sleap-track
#1784Allowing inference on multiple videos via
sleap-track
#1784Changes from 10 commits
132a1ea
e867ec0
babaa77
83f444a
b0ac880
dcc7a63
35db452
6f0c929
bd2b016
ec4c26d
abdc57c
5ffdc96
f179f5e
af565cb
8568cc3
ead7af8
8f0df1c
760059f
ff706d8
beb5e1e
55bfe4b
3b9cd45
be02a7d
6a481c3
488edde
4443686
d86123d
ae11b8d
fb587e5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optimize conditional assignment using a ternary operator.
The current
if-else
block for settingdata_path
can be simplified using a ternary operator, which makes the code cleaner and more concise.Committable suggestion
Tools
Ruff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider refactoring provider creation for clarity and modularity.
The code for creating providers based on file types is spread across multiple conditional branches. Consider refactoring this into a separate function or method to improve clarity and maintainability.
Also applies to: 5347-5352
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve error handling in file reading.
Currently, the error handling in the file reading process just prints an error message. It might be beneficial to either raise an exception or handle the error in a way that doesn't stop the execution, depending on the intended behavior of the application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic to handle multiple video inputs looks good.
The logic to compile files into a list for iteration and the creation of providers based on file types are well implemented. However, consider refactoring the provider creation into a separate function for better modularity and clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve error handling for missing tracker specification.
The error message is clear, but consider providing more guidance or a direct link to documentation on how to specify a tracker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review output path handling logic.
The handling of the output path, especially when multiple inputs are given, needs careful attention. Consider refining the logic to ensure that the output path is correctly set in all scenarios.
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add output folder as an option when the input is a folder.
This suggestion addresses the need to specify an output folder when processing multiple video files from a directory.
Do you want me to generate the code to implement this feature or open a GitHub issue to track this task?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resetting
output_path
might lead to unintended behavior.The reset of
output_path
at the end of each iteration could lead to unexpected behavior in subsequent iterations, especially ifargs.output
is modified during the process.Committable suggestion