Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase range on batch size #1513

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Conversation

roomrys
Copy link
Collaborator

@roomrys roomrys commented Sep 21, 2023

Description

The default range for the batch size only allows up to two digits. This sets the range for the batch size from 1 to 200.

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Read and sign the CLA and add yourself to the authors list
  • Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

@roomrys roomrys mentioned this pull request Sep 21, 2023
3 tasks
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #1513 (74c8176) into develop (c76e602) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1513   +/-   ##
========================================
  Coverage    73.11%   73.12%           
========================================
  Files          134      134           
  Lines        23972    23972           
========================================
+ Hits         17528    17529    +1     
+ Misses        6444     6443    -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roomrys roomrys marked this pull request as ready for review September 22, 2023 18:51
Copy link
Contributor

@shrivaths16 shrivaths16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@roomrys roomrys merged commit 4100153 into develop Sep 25, 2023
9 checks passed
@roomrys roomrys deleted the liezl/increase-allowable-batch-size branch September 25, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants