-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow tracking on Instance
s (by adding Instance.tracking_score
)
#1302
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1302 +/- ##
===========================================
- Coverage 72.36% 72.36% -0.01%
===========================================
Files 133 133
Lines 23662 23675 +13
===========================================
+ Hits 17123 17132 +9
- Misses 6539 6543 +4
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Quick question: what happens when there is a user |
All instances in the labeled frame were being considered individually. I've added the following to prefer user labeled instances in the frame if any: Lines 1192 to 1213 in 1ea047d
|
Holding off on this PR since it would require a file format update... best to be worn in on the develop branch for a bit before tacking onto the release. This mean that retracking can only be done on prediction-only projects until this PR is merged (i.e. users need to remove their user-labeled instances before retracking to avoid error). |
Description
Prior to Allow Retracking, we did not allow any tracking on user instances. Since re-tracking enables users to run tracking on user instances, we now need to either add a
tracking_score
attribute to user-instances, or refrain from assigning the tracking score if the matched instance is a user instance (see #1301). This PR adds anInstance.tracking_score
attribute and updates spots where thetracking_score
is written (including aFORMAT_ID
bump inLabelsV1Adaptor
).Types of changes
Does this address any currently open issues?
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️