Expose supervised ID models to GUI #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/supervised_id_gui
…/supervised_id_gui
…/supervised_id_gui
Codecov Report
@@ Coverage Diff @@
## develop #1213 +/- ##
===========================================
- Coverage 72.36% 72.31% -0.05%
===========================================
Files 132 132
Lines 23502 23526 +24
===========================================
+ Hits 17008 17014 +6
- Misses 6494 6512 +18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roomrys
reviewed
Mar 14, 2023
sleap/gui/learning/dialog.py
Outdated
Comment on lines
362
to
371
| if recent_cfg_info.head_name in ("multi_class_topdown"): | ||
| return "top-down-id" | ||
| if recent_cfg_info.head_name in ("centroid", "centered_instance"): | ||
| return "top-down" | ||
| if recent_cfg_info.head_name in ("multi_instance"): | ||
| return "bottom-up" | ||
| if recent_cfg_info.head_name in ("single_instance"): | ||
| return "single" | ||
| if recent_cfg_info.head_name in ("multi_class_bottomup"): | ||
| return "bottom-up-id" |
There was a problem hiding this comment.
Most of these are not tuples (except for the "top-down" check). Thus, if the recent_cfg_info.head_name were "multi_class", then it would be in "multi_class_topdown" and in "multi_class_bottomup". This likely won't be a problem since the recent_cfg_info.head_name is set from only a few options, but we may not be doing the check we thought we were.
roomrys
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add supervised ID models to GUI
Types of changes
Does this address any currently open issues?
[list open issues here]
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️