modernize Babel config #1721
Merged
modernize Babel config #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/systemui/theme-ui/D6n2T9AAsVYD2SvYq11vsRpEXmZf |
hasparus
changed the title
Closed
lachlanjc
approved these changes
May 7, 2021
hasparus
force-pushed
the
preset-env-loose
branch
from
5dd2b45
to
f32a6e8
Compare
|
lerna failed on canary release. Releasing so many packages is bit flaky, but this PR is a nice change to bundle size regardless. https://github.com/system-ui/theme-ui/pull/1721/checks?check_run_id=2617831975 |
hasparus
force-pushed
the
preset-env-loose
branch
from
6e98050
to
72bae03
Compare
[breaking] Internet Explorer 11 is no longer supported.
Babel Preset Env configuration was changed to:
```
{
bugfixes: true,
loose: true,
modules: false,
targets: '> 0.25%, not dead, not ie 11',
}
```
If you're targetting old browsers, you can transpile your node_modules
to ensure full control and compatibility.
See Babel Preset Env docs: https://babeljs.io/docs/en/babel-preset-env
hasparus
force-pushed
the
preset-env-loose
branch
from
72bae03
to
0d9b13b
Compare
|
We're dropping almost 10 KB! @lachlanjc I'm almost ready to merge when you give it another look.
To-Do for this PR:
|
hasparus
changed the title
|
🚀 PR was released in |
hasparus
added
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit of this PR hase the same configuration for
@babel/preset-envEmotion uses (if I'm not wrong — emotion/babel-preset-emotion-dev/src/index.js).Enabling
looseresulted with 20% reduction in build size compared to currentdevelop.Release notes
All Theme UI package became on average 34% lighter! 🪶 It's 9.5kB if you sum all of them!
The trade-off is, Babel config has changed and it no longer supports Internet Explorer 11.
If you need to support legacy browsers, you can transpile node_modules (e.g. with next-transpile-modules).
Published prerelease version:
v0.9.0-develop.1Changelog
Release Notes
modernize Babel config (#1721)
All Theme UI package became on average 34% lighter! 🪶 It's 9.5kB if you sum all of them!
The trade-off is, Babel config has changed and it no longer supports Internet Explorer 11.
If you need to support legacy browsers, you can transpile node_modules (e.g. with next-transpile-modules).
🚀 Enhancement
@theme-ui/preset-base,@theme-ui/preset-bootstrap,@theme-ui/sidenav,@theme-ui/typography🐛 Bug Fix
@theme-ui/componentsdevelop@theme-ui/components📝 Documentation
Authors: 2