Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style DocSearch #1714

Merged
merged 6 commits into from
May 7, 2021
Merged

style DocSearch #1714

merged 6 commits into from
May 7, 2021

Conversation

hasparus
Copy link
Member

@hasparus hasparus commented May 4, 2021 •
edited
Loading

Sup mate. Wanna take a look at it again? I made the styling consistent with current theme and disabled the search on mobile (yeah, weak move, but we'd need more work to make search results responsive).

Version

Published prerelease version: v0.8.5-develop.0

Changelog

📝 Documentation

Authors: 2

@hasparus hasparus requested a review from lachlanjc May 4, 2021 07:41
@vercel
Copy link

vercel bot commented May 4, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/systemui/theme-ui/CUt2bg1MeQ3QG6HbZMBu8bMhCnTt
✅ Preview: https://theme-ui-git-docsearch-systemui.vercel.app

@hasparus hasparus added affects-docs Changes affect documentation, but not only documentation documentation Changes only affect the documentation and removed affects-docs Changes affect documentation, but not only documentation labels May 4, 2021
lachlanjc
lachlanjc approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@lachlanjc lachlanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! We definitely want to enable search on vertical mobile at some point, but this is nonetheless a big improvement over having none at all.

@hasparus hasparus merged commit 49e0e98 into develop May 7, 2021
@hasparus hasparus deleted the docsearch branch May 7, 2021 10:26
@hasparus hasparus added the prerelease This change is available in a prerelease. label May 7, 2021
@hasparus hasparus mentioned this pull request May 22, 2021
Merged
@hasparus
Copy link
Member Author

🚀 PR was released in v0.9.0 🚀

@hasparus hasparus added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lachlanjc lachlanjc lachlanjc approved these changes

Assignees
No one assigned
Labels
documentation Changes only affect the documentation released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hasparus @lachlanjc @atanasster