Submitter: bump fee cap with tip cap #2412
Conversation
|
Warning Rate Limit Exceeded@dwasse has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 30 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates aim to enhance gas fee management in the Ethergo project. Changes include dynamic fee calculations to prevent exceeding a set maximum, an increase in the default gas bump percentage for better network alignment, and refined gas price setting logic, especially for EIP1559 support. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2412 +/- ##
===================================================
+ Coverage 46.84711% 46.87817% +0.03105%
===================================================
Files 400 400
Lines 30591 30575 -16
Branches 83 83
===================================================
+ Hits 14331 14333 +2
+ Misses 14726 14714 -12
+ Partials 1534 1528 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Deploying sanguine-fe with
|
| Latest commit: |
e71d4b7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://86bf0964.sanguine-fe.pages.dev |
| Branch Preview URL: | https://feat-bump-fee-cap.sanguine-fe.pages.dev |
![coderabbitai[bot]](https://github.com/avatars/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: .coderabbit.yaml
Files selected for processing (3)
- ethergo/chain/gas/cmp.go (2 hunks)
- ethergo/submitter/config/config.go (1 hunks)
- ethergo/submitter/submitter.go (2 hunks)
Additional Context Used
Additional comments not posted (3)
ethergo/chain/gas/cmp.go (1)
96-102: The logic for updating theGasFeeCapbased on themaxPricecomparison is sound. However, it's important to ensure that thelogger.Warnfcall provides enough context for debugging. Consider including thepercentIncreaseandbaseFeevalues in the log message for better traceability.ethergo/submitter/config/config.go (1)
60-61: The update toDefaultGasBumpPercentagefrom 5 to 10 is clear and aligns with the PR objectives. Ensure that the reference link provided is accessible and relevant to the context.ethergo/submitter/submitter.go (1)
370-381: The logic for fetching and setting theGasFeeCapandGasTipCapbased on EIP1559 support is correctly implemented. However, ensure that theshouldBumpflag is used appropriately throughout the function to prevent unnecessary gas price bumps when the maximum configured gas price is reached.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: .coderabbit.yaml
Files selected for processing (1)
- ethergo/chain/gas/cmp_test.go (3 hunks)
Additional Context Used
Additional comments not posted (3)
ethergo/chain/gas/cmp_test.go (3)
4-7: The addition ofmath/big,testing, andtimeimports, along with the reordering of import statements, aligns with Go conventions and supports the updated logic in the test cases. Good practice to keep standard library and external packages grouped and separated.
410-410: The update ofexpectedGasFeeCaptobig.NewInt(110)in the dynamic transaction test case aligns with the PR's objective of introducing dynamic gas fee calculations. Consider adding a comment explaining the choice of110as the new expected value for clarity and future reference.
1-10: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-510]
The changes in
cmp_test.go, including the addition of new imports, updates to test cases, and the integration of dynamic gas fee calculation logic, are well-integrated and consistent with the existing codebase. The updates enhance the test coverage and align with the PR's objectives to improve gas fee calculation accuracy and efficiency.
Description
Instead of using our max gas price for gas fee cap, we use eth.suggestGasPrice() for this value, and bump it in accordance with tip cap.
Metadata
Summary by CodeRabbit
New Features
Refactor
Chores