RFQ/Submitter Fixes

[trajan0x]

• Unstick existing in submitter: 0xdc unstuck. 0xdd optimism issues remain
• Revert replace condition Fix: submitter ReplacedOrConfirmed condition #2406
• Change default bump from 5->10% (min fee to replace an existing transaction in geth): Set submitter DefaultGasBumpPercentage to 10 #2411
• bump both priority fee and fee cap by max(current+10%, new suggested fee). New suggested fee calculated by (for london) eth_gasPrice Submitter/dynamic tx fees [goreleaser] #2432
• Start Fee cap lower than 10% and only bump by a minimum of 10% (on both priority fee and tip cap)
  Submitter/dynamic tx fees [goreleaser] #2432
• Should not bump any transactions greater than the current pending nonce/submitting Submitter/dynamic tx fees [goreleaser] #2432
• Not bump above current gas balance Submitter: check gas balance when setting gas price #2420
• Prometheus Metrics (pending count + longest pending)
• Remove is_l2 as a config param Submitter: remove IsL2 param #2442
• Allow tx type to change in flight enforce txtype #2413 (is this actually working??)
• Add a periodic garbage collector for old txes to prevent db bloat Submitter: add reaper process #2768

[greptile-apps]

Implementation Steps:

1. Unstick existing in submitter:

   • Investigate and resolve issues with transactions 0xdc and 0xdd in the submitter logic.

2. Revert replace condition:

   • Revert changes related to the replace condition in the submitter logic.

3. Change default bump from 5% to 10%:

   • Update DefaultGasBumpPercentage in config/config.go to 10.

   const DefaultGasBumpPercentage = 10

4. Bump both priority fee and fee cap by max(current+10%, new suggested fee):

   • Modify bumpGasFromPrevTx in submitter.go to bump both GasFeeCap and GasTipCap by the maximum of the current value plus 10% or the new suggested fee.

   transactor.GasFeeCap = gas.BumpByPercent(core.CopyBigInt(prevTx.GasFeeCap()), bumpPct)
   transactor.GasTipCap = gas.BumpByPercent(core.CopyBigInt(prevTx.GasTipCap()), bumpPct)

5. Start Fee cap lower than 10% and only bump by a minimum of 10%:

   • Ensure initial fee cap is set lower than 10% and bump by a minimum of 10% in applyGasFloor and applyGasCeil methods in submitter.go.

6. Should not bump any transactions greater than the current pending nonce/submitting:

   • Add logic in SubmitTransaction to check the current pending nonce and avoid bumping transactions with a nonce greater than the current pending nonce.

7. Not bump above current gas balance:

   • Ensure gas bumping logic in applyGasCeil does not exceed the current gas balance.

8. Prometheus Metrics (pending count + longest pending):

   • Implement Prometheus metrics to track the pending transaction count and the longest pending transaction duration.

9. Remove is_l2 as a config param:

   • Remove is_l2 parameter from the configuration in config/config.go and update related logic.

10. Allow tx type to change in flight:

    • Ensure transaction type can change during submission in SubmitTransaction method.

11. Add a periodic garbage collector for old txes to prevent db bloat:

    • Implement a periodic garbage collector in submitter.go to clean up old transactions from the database.

References

/ethergo/submitter/submitter.go
/ethergo/submitter/config/config.go
/ethergo/submitter
/ethergo/submitter/config
/ethergo/submitter/db

Ask Greptile