Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sdk-router): skip RFQ tests for tracking older txs #2333

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

ChiTimesChi
Copy link
Collaborator

@ChiTimesChi ChiTimesChi commented Mar 21, 2024

Description
Skipping the failing CI tests for now.

Metadata

Summary by CodeRabbit

  • Refactor
    • Updated FastBridgeRouter class to better support tracking of legacy transactions.
  • Tests
    • Modified test suite for SynapseRFQ to skip certain tests.

Copy link
Contributor

coderabbitai bot commented Mar 21, 2024

Walkthrough

The recent updates focus on enhancing the FastBridgeRouter class to better support tracking of both new and legacy transactions. Additionally, adjustments in the test suite improve the handling of SynapseRFQ related tests by selectively skipping them under certain conditions, ensuring a more efficient testing process.

Changes

Files Change Summary
.../rfq/fastBridgeRouter.ts Added comments in getSynapseTxId and getBridgeTxStatus for legacy transaction tracking support.
.../src/sdk.test.ts Modified SynapseRFQ tests to skip specific tests within the describe block.

🐇✨
In the land of code, where the digital grass grows,
A rabbit hopped, tweaking lines and prose.
"Legacy and new, both shall flow,
With bridges and synapses, all in a row.
Skip a test, hop a line, let the green tests show!"
🌟🐾

(\(\  
(-.-)  
o_(")(")

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.86579%. Comparing base (4032665) to head (32b52ff).
Report is 30 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##              master       #2333   +/-   ##
=============================================
  Coverage   47.86579%   47.86579%           
=============================================
  Files            360         360           
  Lines          26942       26942           
  Branches          83          83           
=============================================
  Hits           12896       12896           
  Misses         12708       12708           
  Partials        1338        1338           
Flag Coverage Δ
packages 90.62500% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 32b52ff
Status: ✅  Deploy successful!
Preview URL: https://6730a542.sanguine-fe.pages.dev
Branch Preview URL: https://sdk-skip-failing-tests.sanguine-fe.pages.dev

View logs

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 4

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between ff5a135 and 32b52ff.
Files selected for processing (2)
  • packages/sdk-router/src/rfq/fastBridgeRouter.ts (2 hunks)
  • packages/sdk-router/src/sdk.test.ts (2 hunks)

packages/sdk-router/src/sdk.test.ts Show resolved Hide resolved
packages/sdk-router/src/sdk.test.ts Show resolved Hide resolved
@trajan0x trajan0x mentioned this pull request Mar 21, 2024
@ChiTimesChi ChiTimesChi merged commit d652041 into master Mar 21, 2024
36 checks passed
@ChiTimesChi ChiTimesChi deleted the sdk/skip-failing-tests branch March 21, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant