Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(sdk-router): skip RFQ tests for tracking older txs #2333

Merged
merged 2 commits into from
Mar 21, 2024
Merged

test(sdk-router): skip RFQ tests for tracking older txs #2333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07fa604
Skip failing RFQ tracking tests (older txs not tracked)
ChiTimesChi Mar 21, 2024
32b52ff
Put future TODOs re:RFQ tracking
ChiTimesChi Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/sdk-router/src/rfq/fastBridgeRouter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ export class FastBridgeRouter implements SynapseModule {
* @inheritdoc SynapseModule.getSynapseTxId
*/
public async getSynapseTxId(txHash: string): Promise<string> {
// TODO: this should support older instances of FastBridge to track legacy txs
ChiTimesChi marked this conversation as resolved.
Show resolved Hide resolved
const fastBridgeContract = await this.getFastBridgeContract()
const fastBridgeLog = await getMatchingTxLog(
this.provider,
Expand All @@ -114,6 +115,7 @@ export class FastBridgeRouter implements SynapseModule {
* @inheritdoc SynapseModule.getBridgeTxStatus
*/
public async getBridgeTxStatus(synapseTxId: string): Promise<boolean> {
// TODO: this should support older instances of FastBridge to track legacy txs
ChiTimesChi marked this conversation as resolved.
Show resolved Hide resolved
const fastBridgeContract = await this.getFastBridgeContract()
return fastBridgeContract.bridgeRelays(synapseTxId)
}
Expand Down
4 changes: 2 additions & 2 deletions packages/sdk-router/src/sdk.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1187,7 +1187,7 @@ describe('SynapseSDK', () => {
})
})

describe('SynapseRFQ', () => {
describe.skip('SynapseRFQ', () => {
ChiTimesChi marked this conversation as resolved.
Show resolved Hide resolved
const arbSynRFQ = '0x6C0771aD91442D670159a8171C35F4828E19aFd2'
const events = 'BridgeRequested'

Expand Down Expand Up @@ -1342,7 +1342,7 @@ describe('SynapseSDK', () => {
})
})

describe('SynapseRFQ', () => {
describe.skip('SynapseRFQ', () => {
ChiTimesChi marked this conversation as resolved.
Show resolved Hide resolved
it('OP -> ARB', async () => {
const txStatus = await synapse.getBridgeTxStatus(
SupportedChainId.ARBITRUM,
Expand Down
Loading