Skip to content

Commit

Permalink
test(sdk-router): skip RFQ tests for tracking older txs (#2333)
Browse files Browse the repository at this point in the history
* Skip failing RFQ tracking tests (older txs not tracked)

* Put future TODOs re:RFQ tracking
  • Loading branch information
ChiTimesChi authored Mar 21, 2024
1 parent 2b8a743 commit d652041
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions packages/sdk-router/src/rfq/fastBridgeRouter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ export class FastBridgeRouter implements SynapseModule {
* @inheritdoc SynapseModule.getSynapseTxId
*/
public async getSynapseTxId(txHash: string): Promise<string> {
// TODO: this should support older instances of FastBridge to track legacy txs
const fastBridgeContract = await this.getFastBridgeContract()
const fastBridgeLog = await getMatchingTxLog(
this.provider,
Expand All @@ -114,6 +115,7 @@ export class FastBridgeRouter implements SynapseModule {
* @inheritdoc SynapseModule.getBridgeTxStatus
*/
public async getBridgeTxStatus(synapseTxId: string): Promise<boolean> {
// TODO: this should support older instances of FastBridge to track legacy txs
const fastBridgeContract = await this.getFastBridgeContract()
return fastBridgeContract.bridgeRelays(synapseTxId)
}
Expand Down
4 changes: 2 additions & 2 deletions packages/sdk-router/src/sdk.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1187,7 +1187,7 @@ describe('SynapseSDK', () => {
})
})

describe('SynapseRFQ', () => {
describe.skip('SynapseRFQ', () => {
const arbSynRFQ = '0x6C0771aD91442D670159a8171C35F4828E19aFd2'
const events = 'BridgeRequested'

Expand Down Expand Up @@ -1342,7 +1342,7 @@ describe('SynapseSDK', () => {
})
})

describe('SynapseRFQ', () => {
describe.skip('SynapseRFQ', () => {
it('OP -> ARB', async () => {
const txStatus = await synapse.getBridgeTxStatus(
SupportedChainId.ARBITRUM,
Expand Down

0 comments on commit d652041

Please sign in to comment.