attempt to fix golangci-lint #2331

This reverts commit 436c15d.

…Ests

* RM old IInterchainModule, delete Interchain.sol code ahead of DB Integration * rename to InterchainClient * interchainSend() * interchainReceive() and corresponding test * remove forge console.log * Add interfaces for SynapseModule & InterchainClient

…ommitee

* Implement SynapseModule w/ ECREcover Around InterchainDB contract + TEsts * fix typo in event name * Interchain + InterchainDB integration (#2046) * RM old IInterchainModule, delete Interchain.sol code ahead of DB Integration * rename to InterchainClient * interchainSend() * interchainReceive() and corresponding test * remove forge console.log * Add interfaces for SynapseModule & InterchainClient * add keccak'd datahash to event emit * change variable name * Fix event variabl ename

* Scaffold ThresholdECDSA library * Start working on the tests * Add some revert tests * Start working on verify hash tests * More tests * More revert tests * Implement `verifySignedHash` * Chore: test cleanup

* More events to a separate dir * Update contracts * Update tests * Chore: forge fmt

This reverts commit f231221.

* expose view for isExecutable * fix build issues * Functionalize view * Seperate execution logic into view subfunctions * only execute message once * add event on execution * add natspec, fix interface

* feat(InterchainClientV1): add options param for gas limit & airdrop settings - Include `options` parameter in `InterchainTransaction` struct and related functions to allow setting message gas limit and gas airdrop parameters. - Update event signatures to include `options` parameter. - Adjust `_generateTransactionId` function to incorporate `options` in transaction ID generation. - Modify `interchainSend` and `interchainExecute` functions to handle `options` parameter. - Update interface `IInterchainClientV1` and tests to reflect changes. * Remove address/bytes32 to conversions in place of TypeCasts lib * onylOwner setLinkedClient * remove unused function argument interchainExecute() * - Introduced the use of OptionsLib for decoding transaction options within the InterchainClientV1 contract. - Enabled dynamic gas limits for appReceive calls based on options specified in incoming interchain transactions. * remove todo for gas limit * comments * comments

* Isolate some common logic into abstract contract * Scaffold `ThresholdECDSAModule` * Add more views * Implement management tests * Implement management actions * Add `InterchainDB` Mock * Reorg events following #2049 * Also emit ethSingedMsg hash * More `InterchainModule` errors * Implement tests for fee collector management * Fix: use the entry hash for signing * Implement `feeCollector` management * Start doing source tests * Add GasOracle interface * Update `verifyEntry()` interface * Add source chain tests * Implement source chain funcs * Add tests: `bytes` for signatures instead of `bytes[]` * Implement library update * Simplify math * Implement `verifyEntry()` * Add tests for destination chain * Don't use infinity as default threshold * Check source chain id in any InterchainModule * Deprecate old SynapseModule * Fix ClientV1 test * Chore: cleanup * Chore: renamoooor * Revert "Fix ClientV1 test" This reverts commit e724c38. * Revert "Chore: cleanup" This reverts commit 41949cd. * Fix ClientV1 test * Chore: cleanup

* Add encode/decode versioned options * Add `OptionsV1` struct * Use `OptionsV1` in other contracts

* First draft for Executor interface * Interface for execution fees custody contract

* Update `interchainSend()` interface * Add execution service interaction in `interchainSend()` * Add `executionFees` to InterchainClient * Add mocks for the new interfaces * Remove variable to fix stack too deep * Update the tests * Chore: small cleanup for imports

* Use dbNonce in `InterchainEntry` struct * Update InterchainDB: source chain logic * Update InterchainDB: destination chain logic * Update InterchainDB tests * Use `dbNonce` in InterchainClient * Update the rest of the tests

* init basic script for testnet deploy * add testnet broadcasts

Contracts Communication Branch Re-Sync

* Update `EntryVerified` event and its unit test * Emit the updated event

* First draft for Executor interface * Interface for execution fees custody contract

* Update `interchainSend()` interface * Add execution service interaction in `interchainSend()` * Add `executionFees` to InterchainClient * Add mocks for the new interfaces * Remove variable to fix stack too deep * Update the tests * Chore: small cleanup for imports

* Use dbNonce in `InterchainEntry` struct * Update InterchainDB: source chain logic * Update InterchainDB: destination chain logic * Update InterchainDB tests * Use `dbNonce` in InterchainClient * Update the rest of the tests

* init basic script for testnet deploy * add testnet broadcasts

… Execution depending on address(0) (#2076)

[WIP] Off-Chain Sin

* Isolate and split ClientV1 events * Merge generic source chain events * `forge fmt` * Update source chain events * Update destination events * Fix stack too deep error * Add `verificationFee` to the event * rename * client bump * Merge source chain events * Swap `message` and `srcModules` for better readability + fix stack too deep --------- Co-authored-by: ChiTimesChi <88190723+ChiTimesChi@users.noreply.github.com> Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com> Co-authored-by: trajan0x <83933037+trajan0x@users.noreply.github.com>

* Add slither, test workflows * Add solhint config * Add lint scripts

* Add `AppConfig` library and its coverage * Update InterchainApp interface * Update the ClientV1 test * Use versioned AppConfig in ClientV1

* Isolate `InterchainTransaction` operations to a separate library * Add library coverage * Update execute/isExecutable * Update interchainSend * Update tests * Simplify the `transactionId` scheme for now * Chore: `forge fmt`

* Update IApp interface to pass the message * Pass message to the app * Allow to specify higher gas limit * Make execute payable * Define test with requested gas airdrop * Implement gas airdrop passing

…nguine into feat/communication

This reverts commit c2f6833.

…cation

This reverts commit 947d00e.

#2082) * Add ExecutionFees.sol collector contract & record upon execution service provided to interchainSend() * MVP ExecutionFees by adding executorEOA() * Add events to ExecutionFees.sol, enable anyone to claim on behalf of executors * fix global imports * add OZ Address library * `forge fmt` * Use AccessControl in ExecutionFees * Specify events and custom errors * Define the tests with new scenarios * Update implementation to pass the tests * Modify tests: - Allow adding fees for already recorded executor - Allow recording executor when no fees exist * Update implementation * Add more views * Add tests for the new views * Update mappings * Chore: cleanup * Simplify implementation by making mappings public * Update tests --------- Co-authored-by: ChiTimesChi <88190723+ChiTimesChi@users.noreply.github.com>

This reverts commit 23b782d.

- Introduce IGasOracle interface and OptionsLib for handling execution options. - Add gasOracle state variable and setGasOracle function for updating the gas oracle address. - Implement onlyInterchainClient modifier to restrict execution requests to the designated interchain client. - Update requestExecution to enforce a minimum execution fee based on the calculated fee from getExecutionFee. - Enhance getExecutionFee to calculate fees using the gas oracle and options, supporting versioned options handling. - Add events for updating gas oracle and interchain client addresses. - Minor code style adjustments for consistency. This update enables dynamic execution fee calculation based on gas costs and introduces infrastructure for future options-based execution enhancements.

…lders of testnet setup

golang/go#50554 rebuild

* Remove `_getAppConfig` * Merge `_getApprovedResponses` and `_getFinalizedResponsesCount` * Update tests * Fix incorrect test * Rework: `_isExecutable` -> `_assertExecutable` * Use custom errors * Chore: visibility * Chore: ordering * Add verification fee check * Chore: make solhint happy * Fix: record the executor address, not the status * Expose transaction -> executor * Fix: check chain IDs when sending/executing * Chore: use library for encoding * Fix: interchain receive test * Resolve some TODOs, add new ones * Expose additional sending function * Fix: make interchainDB immutable * Update tests * Update deploy script * Chore: docs, nonce TODO * Expose fee getter in InterchainClient * Feat: write proof of execution

* Remove nonce from InterchainTransaction struct * Remove client nonce * Use dbNonce in appReceive * Return txId and dbNonce back to App when sending a message

* Make Interchain App interface minimalistic * Start doing InterchainAppBase * Set app config * Link remote app * Add thin wrapper for setting a linked app * Add/remove trusted modules * Implement default values for module lists * Set execution service * Send interchain message * Overridable getter for app config * Implement minimal app functions * Add checks around interchain client * Add example app * Update base apps to use the latest interface * App versioning * Rename AppBase to AppV1

* interchain * comment fix --------- Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>

Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>

Feat/execution service

* Functions to add/remove multiple verifiers * Chore: cleanup * Remove unused func * Add test coverage for new management funcs * Chore: keep test function names consistent * Scaffold incentivized permisionless claiming * Specify the unit tests for the new claim workflow * Implement fee claiming * Chore: deduplicate code a bit * Scaffold configurable gas limit * Add unit tests for configurable gas limits * Implement configurable gas limit for verifyEntry * Fix: don't allow adding zero address signer * Chore: fix/suppress linter warnings

* Chore: standardize owner/admin in constructor * Update scripts and tests

* Emit client address when execution is requested * Expose linked client addresses * Fix: check that linked client exists on send/receive * Fix client tests

* Initial devops setup * Add solidity-devops as a dev dep * Add scripts [UGLY, export properly] * Add deploy scripts * Deploy on ETH Sepolia * Reorder deployments * Deploy on OP sepolia * Config for OP sepolia * Move deploy scripts * Deploy GasOracle mocks * Add config scripts * Add testnet configs * Use newer package, remove dupe scripts * New naming :happy: * Chore: fix shellcheck errors

* Refactor config to use slice for chains and add ChainID field; adjust executor logic accordingly * [goreleaser]

upgrade [goreleaser] to support go 1.22 (#2200)

* Isolate OwnableApp abstraction * Add PingPongApp * Make gas limit configurable * Fix import in the script * Script to configure PingPong * Deploy PingPong apps * Fix .sh options, add ping pong to workflows * Fix: set execution service & client * New deployments + Added Configuration for Execution Service * fix failed to resolve ds-test/test.sol? * regen sin-executor * [goreleaser] * [goreleaser] --------- Co-authored-by: aureliusbtc <82057759+aureliusbtc@users.noreply.github.com>

…mism#9641)

…ism/optimism#9641)" This reverts commit 30b387b.

* Add param to the error and update unit tests * Update implementation to satisfy the tests * Make other errors more explicit and update their tests * Chore: fix linter warnings * Implement explicit errors * Update SynapseModule tests

* Add separate for module entries with aux data * InterchainModule: handle relayed entry+data * InterchainModule: fill module data on src chain * Adjust tests * Introduce SynapseGasOracle * SynapseModule: fill gas data * SynapseModule: receive gas data * Update gas oracle mock * Update GasOracleMock references * Update packages/contracts-communication/contracts/modules/SynapseModule.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update configs --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

This reverts commit 87ac5c3.

This reverts commit d2717b6.

* Scaffold V1 version of synapse gas oracle * Add unit tests for getters and management * GasOracle: track local native token price * GasOracle: track remote gas data * GasOracle: value estimation/conversion * Add configuration script for GasOracle * Update deploy/config workflows

…ally fixed in #2204)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

attempt to fix golangci-lint #2331

attempt to fix golangci-lint #2331

Commits on Feb 15, 2024

Commits on Feb 16, 2024

Commits on Feb 17, 2024

Commits on Feb 19, 2024

Commits on Feb 20, 2024

Commits on Feb 21, 2024

Commits on Feb 22, 2024

Commits on Feb 23, 2024

Commits on Feb 24, 2024

Commits on Feb 25, 2024

Commits on Feb 26, 2024

Commits on Feb 27, 2024

Commits on Feb 28, 2024

Commits on Feb 29, 2024

Commits on Mar 1, 2024

Commits on Mar 3, 2024

Commits on Mar 4, 2024

Commits on Mar 8, 2024

Commits on Mar 9, 2024

Commits on Mar 10, 2024

Commits on Mar 13, 2024

Commits on Mar 15, 2024

Commits on Mar 18, 2024

Commits on Mar 21, 2024