Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/execution service #2098

Merged
merged 10 commits into from
Feb 28, 2024
Merged

Feat/execution service #2098

merged 10 commits into from
Feb 28, 2024

Conversation

aureliusbtc
Copy link
Contributor

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 25, 2024

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@codecov Codecov
Copy link

codecov bot commented Feb 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 63.21839% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 47.57687%. Comparing base (879b6fd) to head (c807b4f).
Report is 129 commits behind head on feat/communication.

Files Patch % Lines
sin-executor/executor/executor.go 62.74510% 13 Missing and 6 partials ⚠️
sin-executor/testutil/deployers.go 67.85714% 6 Missing and 3 partials ⚠️
sin-executor/testutil/typecast.go 0.00000% 4 Missing ⚠️
Additional details and impacted files 
@@                     Coverage Diff                      @@
##           feat/communication       #2098         +/-   ##
============================================================
+ Coverage            46.27769%   47.57687%   +1.29917%     
============================================================
  Files                     265         241         -24     
  Lines                   18013       17952         -61     
  Branches                   79          83          +4     
============================================================
+ Hits                     8336        8541        +205     
+ Misses                   8745        8459        -286     
- Partials                  932         952         +20
Flag Coverage Δ
cctp-relayer ?
committee 62.62626% <ø> (-0.43826%) ⬇️
core ?
git-changes-action ?
packages 90.51808% <ø> (-0.50360%) ⬇️
promexporter ?
release-copier-action ?
screener-api ?
sin-executor 64.28571% <63.21839%> (-0.96854%) ⬇️
sinner ?
terraform-provider-helmproxy ?
terraform-provider-iap ?
terraform-provider-kubeproxy ?
tfcore ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aureliusbtc
feat: Enhance ExecutionService with gas oracle and options handling
5a42ebe 
- Introduce IGasOracle interface and OptionsLib for handling execution options.
- Add gasOracle state variable and setGasOracle function for updating the gas oracle address.
- Implement onlyInterchainClient modifier to restrict execution requests to the designated interchain client.
- Update requestExecution to enforce a minimum execution fee based on the calculated fee from getExecutionFee.
- Enhance getExecutionFee to calculate fees using the gas oracle and options, supporting versioned options handling.
- Add events for updating gas oracle and interchain client addresses.
- Minor code style adjustments for consistency.

This update enables dynamic execution fee calculation based on gas costs and introduces infrastructure for future options-based execution enhancements.
ChiTimesChi
ChiTimesChi approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@ChiTimesChi ChiTimesChi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's do forge fmt to pass the lint CI :)

@trajan0x trajan0x mentioned this pull request Feb 27, 2024
Closed
@trajan0x
Execution Service Consolidation (#2125) (#2127) (#2128)
c807b4f 
Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>
@trajan0x trajan0x merged commit 9a39094 into feat/communication Feb 28, 2024
48 of 55 checks passed
@trajan0x trajan0x deleted the feat/execution-service branch February 28, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChiTimesChi ChiTimesChi ChiTimesChi approved these changes

@trajan0x trajan0x Awaiting requested review from trajan0x

Assignees
No one assigned
Labels
go Pull requests that update Go code needs-yarn-install size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aureliusbtc @ChiTimesChi @trajan0x