Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix golangci-lint #2331

Closed
wants to merge 303 commits into from
Closed

attempt to fix golangci-lint #2331

wants to merge 303 commits into from

Conversation

trajan0x
Copy link
Contributor

@trajan0x trajan0x commented Mar 21, 2024

Description

This should not be merged directly. If it works, close this make a new pr, merge to master, and then to feat/communication.

Context: on #2234 and child branches golangci-lint has been failing. This comment hints this was a result of old go version.

We were stopped from updating this because of golangci/golangci-lint#3420 (see regression in: #534/#532), but that was fixed w/ the upgrade in #2204.

Unclear why this is not happening on main, but likely a result of upgrading stuff
006ac45c877a31ae7daa1eaa9a64a03a53a40681: synapse-interface preview link
006ac45c877a31ae7daa1eaa9a64a03a53a40681: explorer-ui preview link

trajan0x and others added 7 commits March 10, 2024 11:52
* Scaffold V1 version of synapse gas oracle

* Add unit tests for getters and management

* GasOracle: track local native token price

* GasOracle: track remote gas data

* GasOracle: value estimation/conversion

* Add configuration script for GasOracle

* Update deploy/config workflows
Copy link
Contributor

coderabbitai bot commented Mar 21, 2024

Warning

Rate Limit Exceeded

@trajan0x has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 8 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between c15ddf6 and 01c83a2.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added M-ci Module: CI size/xs labels Mar 21, 2024
@trajan0x trajan0x changed the title attempt to fix golangci-lint (golangci/golangci-lint#3420), theoretic… attempt to fix golangci-lint Mar 21, 2024
Copy link

cloudflare-workers-and-pages bot commented Mar 21, 2024

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1ea27c2
Status: ✅  Deploy successful!
Preview URL: https://69027465.sanguine-fe.pages.dev
Branch Preview URL: https://fix-golang-ci-version.sanguine-fe.pages.dev

View logs

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 59.97305% with 297 lines in your changes are missing coverage. Please review.

Project coverage is 47.60041%. Comparing base (4032665) to head (01c83a2).
Report is 31 commits behind head on master.

Files Patch % Lines
committee/p2p/boot.go 58.92256% 84 Missing and 38 partials ⚠️
committee/node/node.go 64.52703% 74 Missing and 31 partials ⚠️
ethergo/deployer/functional.go 0.00000% 24 Missing ⚠️
committee/db/db.go 13.33333% 13 Missing ⚠️
committee/testutil/typecast.go 0.00000% 8 Missing ⚠️
committee/p2p/validator.go 50.00000% 4 Missing and 2 partials ⚠️
committee/testutil/deployers.go 86.66667% 4 Missing and 2 partials ⚠️
committee/testutil/contracttype.go 84.37500% 3 Missing and 2 partials ⚠️
ethergo/signer/signer/localsigner/signer.go 0.00000% 5 Missing ⚠️
ethergo/submitter/db/service.go 50.00000% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #2331         +/-   ##
===================================================
- Coverage   47.86579%   47.60041%   -0.26539%     
===================================================
  Files            360         381         +21     
  Lines          26942       28359       +1417     
  Branches          83          83                 
===================================================
+ Hits           12896       13499        +603     
- Misses         12708       13450        +742     
- Partials        1338        1410         +72     
Flag Coverage Δ
git-changes-action 53.94265% <ø> (ø)
promexporter 75.00000% <ø> (?)
release-copier-action 19.33333% <ø> (ø)
screener-api 62.80488% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added go Pull requests that update Go code M-explorer-ui M-synapse-interface size/l and removed size/xs labels Mar 21, 2024
@trajan0x trajan0x changed the base branch from feat/communication to master March 21, 2024 10:12
@trajan0x trajan0x marked this pull request as draft March 21, 2024 10:12
@trajan0x trajan0x closed this Mar 21, 2024
@trajan0x trajan0x deleted the fix/golang-ci-version branch March 21, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code M-ci Module: CI M-explorer-ui M-synapse-interface size/l
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants