-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt to fix golangci-lint #2331
Conversation
This reverts commit 436c15d.
* Scaffold V1 version of synapse gas oracle * Add unit tests for getters and management * GasOracle: track local native token price * GasOracle: track remote gas data * GasOracle: value estimation/conversion * Add configuration script for GasOracle * Update deploy/config workflows
Warning Rate Limit Exceeded@trajan0x has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 8 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Deploying sanguine-fe with Cloudflare Pages
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2331 +/- ##
===================================================
- Coverage 47.86579% 47.60041% -0.26539%
===================================================
Files 360 381 +21
Lines 26942 28359 +1417
Branches 83 83
===================================================
+ Hits 12896 13499 +603
- Misses 12708 13450 +742
- Partials 1338 1410 +72
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
This should not be merged directly. If it works, close this make a new pr, merge to master, and then to feat/communication.
Context: on #2234 and child branches golangci-lint has been failing. This comment hints this was a result of old go version.
We were stopped from updating this because of golangci/golangci-lint#3420 (see regression in: #534/#532), but that was fixed w/ the upgrade in #2204.
Unclear why this is not happening on main, but likely a result of upgrading stuff
006ac45c877a31ae7daa1eaa9a64a03a53a40681: synapse-interface preview link
006ac45c877a31ae7daa1eaa9a64a03a53a40681: explorer-ui preview link