Update README.md #54
Open
Update README.md #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrgnicho
reviewed
Jul 19, 2018
| @@ -43,10 +44,10 @@ The project is based on Ubuntu 16.04, ROS Kinect, gazebo 7.0, wstool and catkin | |||
| ## Visualize The Simulation Enviroment | |||
|
|
|||
| ### Setup | |||
| - Source the catkin workspace | |||
| - Source the gilbreth workspace | |||
There was a problem hiding this comment.
Perhaps we should say "gilbreth catkin" workspace
jrgnicho
reviewed
Jul 19, 2018
| @@ -68,7 +69,7 @@ The project is based on Ubuntu 16.04, ROS Kinect, gazebo 7.0, wstool and catkin | |||
| ``` | |||
| roscd gilbreth_gazebo | |||
| source scripts/env_setup.bash | |||
There was a problem hiding this comment.
I think running this script is no longer necessary, can you test that?
There was a problem hiding this comment.
I have tested this and it seems that you are correct, this script is unnecessary to run the gazebo environment.
jrgnicho
reviewed
Jul 20, 2018
| @@ -68,7 +69,7 @@ The project is based on Ubuntu 16.04, ROS Kinect, gazebo 7.0, wstool and catkin | |||
| ``` | |||
| roscd gilbreth_gazebo | |||
| source scripts/env_setup.bash | |||
| roslaunch gilbreth_gazebo gilbreth.launch rviz:=false | |||
| roslaunch gilbreth_gazebo gilbreth_environment.launch rviz:=false | |||
There was a problem hiding this comment.
I believe this has been fixed in another one of your PR's #57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.