-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pdftk no longer maintained, consider using something else? #5
Comments
Thank you for the information, I had no idea that pdftk was problematic. I'll try out the alternatives you suggested. |
@rocketraman If you want to help with testing, see branch |
@svenssonaxel Tried out the issue-5 branch but doesn't see to be working very well for me. The window that opens first shrinks down to a very small size, then the signature is shown in the middle of the first page. None of the controls to move the signature or navigate through pages work. I'm using KDE on Fedora 38. |
@rocketraman Could you please try branch |
Hi @svenssonaxel ! Pretty much the same as before. I see this error on startup:
After startup the window is quite small. The signature is in the middle and cannot be moved as far as I can tell. I also cannot navigate through the pages. If I actually try to save the signature, it writes out a file, but page 3 of my 3 page PDF has been replaced by page 1 with my signature in the middle of the page. |
@rocketraman I'd like some version information to try to reproduce this.
|
Python 3.12.3
which: no pdftk in (...)
10.02.1
qpdf version 11.6.4
fish: Unknown command: pdftk
pdfinfo version 23.08.0
|
@rocketraman |
KDE Plasma 5.27.11 on X11. |
@rocketraman I've tried with kwin 5.27.5, python 3.12.3, tkinter 8.6.13. I wasn't able to reproduce all of the issues, but I'd still like you to pull branch
|
Thanks for the new drop. I'm on KDE Plasma 6.1.1 on Wayland now (after many years of trying Wayland every year and then giving up, I'm finally staying on Wayland this year!). Other updated versions (if not listed here, its the same version as before):
I've given the latest issue-5 branch a try.
|
The window is hard-coded to open with I'm glad page navigation works. The 2s to switch between pages is due to the hacky way a page is shown; it is extracted from the source pdf using I do want to fix the key presses and clicks, though. I've now pushed a debug version. Could you try some key presses and clicks, and send me the output? Thanks! |
That's really small for modern screens, especially high-DPI ones. But yes, it is resizable.
My test PDF is 3 pages, 580kb. Large, but not huge. The temp filesystem is tmpfs backed by NVMe SSDs (and I have plenty of memory so it should never even see the SSD), so it should be pretty quick. For inspiration, maybe you could look at the way pdfarranger does it. In any case, this isn't a huge deal.
Here is the output:
|
Made it adaptive, does that feel better?
I've sped up the startup, at least on my side, and also added debug prints to find out what is taking so long on your side.
This is a little mysterious; I see nothing wrong in this output. I've pushed a heavier load of debug prints. Could you please
|
Yes!
I'm not sure what I'm looking for here...
|
Thank you, I might've found the issue, but not yet solved it. Some pdf signatures work but not others. I have attached
Can you confirm that all of the above is the case for you as well? |
@svenssonaxel Yes, I can confirm the same behavior on my machine for bad-signature.pdf and good-signature.pdf. |
Fixed on my side, can you confirm that everything is working for you now? |
Yes it works! |
@rocketraman Thanks for all your help. Feel free to open new issues for any remaining concerns. |
Hello, this looks like a really useful tool. However, it depends on pdftk, which is no longer maintained. For example, Fedora retired this package six years ago: https://src.fedoraproject.org/rpms/pdftk.
Would you consider using pypdf (Python) or qpdf (C++ with Python bindings) instead?
The text was updated successfully, but these errors were encountered: