Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] remove writeStatic to align with Vite #5618

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Conversation

benmccann
Copy link
Member

Have writeClient write both the client and static files and remove writeStatic. This is a breaking change for adapter authors.

If we were using Vite's publicDir and base options it would put the static files into the client directory. This change will free us up to be able to utilize those options in the future. This change was prototyped in #5601, but it's getting too large and complicated, so I'm breaking it up.

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2022

🦋 Changeset detected

Latest commit: b37d98e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@sveltejs/adapter-cloudflare Patch
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-netlify Patch
@sveltejs/adapter-node Patch
@sveltejs/adapter-static Patch
@sveltejs/adapter-vercel Patch
@sveltejs/kit Patch
@sveltejs/adapter-auto Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann merged commit 8191720 into master Jul 19, 2022
@benmccann benmccann deleted the writeStatic branch July 19, 2022 17:30
gornostay25 pushed a commit to gornostay25/svelte-adapter-bun that referenced this pull request Jul 21, 2022
aloker pushed a commit to validData/svelte-adapter-azure-swa that referenced this pull request Jul 25, 2022
writeStatic has been removed from the adapter API

See sveltejs/kit#5618

fixes geoffrich#52
geoffrich pushed a commit to geoffrich/svelte-adapter-azure-swa that referenced this pull request Jul 25, 2022
writeStatic has been removed from the adapter API

See sveltejs/kit#5618

fixes #52
Karakatiza666 added a commit to Karakatiza666/sveltekit-adapter-chrome-extension that referenced this pull request Jul 30, 2022
elron added a commit to elron/sveltekit-adapter-wordpress-shortcode that referenced this pull request Aug 10, 2022
[breaking] remove writeStatic to align with Vite #5618 (sveltejs/kit#5618)
elron added a commit to elron/sveltekit-adapter-wordpress-shortcode that referenced this pull request Aug 10, 2022
Have writeClient write both the client and static files and remove writeStatic. This is a breaking change for adapter authors.

[breaking] remove writeStatic to align with Vite #5618
sveltejs/kit#5618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants