set Vite's publicDir and base options
#5601
Conversation
🦋 Changeset detectedLatest commit: e1d80c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@benmccann it is the webmanifest file, not the sw: pwa plugin will emit We wrote the sw and workbox-*** assets to the client folder via workbox build or rollup. |
|
With this approach, the static assets get copied into |
Why not just replace static with public folder? I don't need the assets to be written in the output folder. I only need the publicDir to list the assets matching a globPattern. The pwa plugin will use it to include the webmanifest icons in the sw's precache manifest. |
|
That's just how Vite works. Everything in |
| test('Filenames are case-sensitive', async ({ request }) => { | ||
| const response = await request.get('/static.JSON'); | ||
| expect(response.status()).toBe(404); | ||
| }); |
There was a problem hiding this comment.
Vite does not check case sensitivity
There was a problem hiding this comment.
Right, but many servers do, so it's essential that we do too — if we can't get Vite to be strict about casing it's a showstopper for this PR
This reverts commit 44381e4.
|
Closing this for now as it doesn't seem feasible until maybe Vite 4 given current limitations in Vite |
Benefits:
publicDirandbaseare now defined for Vite plugins (should help @userquin with his work supporting SvelteKit invite-plugin-pwa)I would suggest closing #5115 with a suggestion that the issue be filed in the Vite repo