Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Add args to mount in react, svelte, and vue renderers #28385

Merged
merged 12 commits into from
Jul 3, 2024

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Jun 28, 2024

What I did

This add the ability to mount a specific element in the play function itself, similar as how you do it in testing library.

For React:

export const Basic: StoryObj<typeof Button> = {
args: {
disabled: true,
},
async play({ mount, args }) {
await mount(<Button {...args} label={'set in play'} />);
},
};

For Svelte:

export const Basic: StoryObj = {
args: {
disabled: true,
},
async play({ mount, args }) {
await mount(Button, { props: { ...args, label: 'set in play' } });
},
};

For Vue3:

export const Basic: StoryObj<typeof Button> = {
args: {
disabled: true,
},
async play({ mount, args }) {
await mount(Button, { props: { ...args, label: 'set in play' } });
},
};

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-28385-sha-61d0ddf0. Try it out in a new sandbox by running npx storybook@0.0.0-pr-28385-sha-61d0ddf0 sandbox or in an existing project with npx storybook@0.0.0-pr-28385-sha-61d0ddf0 upgrade.

More information
Published version 0.0.0-pr-28385-sha-61d0ddf0
Triggered by @kasperpeulen
Repository storybookjs/storybook
Branch kasper/mount-args
Commit 61d0ddf0
Datetime Wed Jul 3 07:42:20 UTC 2024 (1719992540)
Workflow run 9773832215

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=28385

@kasperpeulen kasperpeulen changed the base branch from next to kasper/mount June 28, 2024 13:33
Copy link

nx-cloud bot commented Jun 28, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 61d0ddf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@kasperpeulen kasperpeulen marked this pull request as ready for review July 1, 2024 14:13
# Conflicts:
#	code/renderers/react/src/types.ts
#	code/renderers/svelte/src/types.ts
#	code/renderers/vue3/src/public-types.test.ts
#	code/renderers/vue3/src/types.ts
Base automatically changed from kasper/mount to next July 3, 2024 08:21
@shilman shilman changed the title Test: Add args to the mount function in the react, svelte and vue renderer Test: Add args to mount in react, svelte, and vue renderers Jul 3, 2024
@kasperpeulen kasperpeulen merged commit 67d9c5b into next Jul 3, 2024
54 of 55 checks passed
@kasperpeulen kasperpeulen deleted the kasper/mount-args branch July 3, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants