Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRA kitchen sink #1285

Closed
wants to merge 15 commits into from
Closed

CRA kitchen sink #1285

wants to merge 15 commits into from

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 15, 2017

Issue: #1220

What I did

Resurrect kitchen sink only PR to decouple it from all the RN disasters going on in the previous PRs

  • renamed cra-storybook => cra-kitchensink
  • added notes, info, knobs, options, centered addon examples to cra-kitchensink.

How to test

npm install && npm run boostrap
cd examples/cra-kitchensink
npm run storybook

@shilman shilman added in progress maintenance User-facing maintenance tasks labels Jun 15, 2017
@codecov
Copy link

codecov bot commented Jun 15, 2017

Codecov Report

Merging #1285 into master will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1285      +/-   ##
==========================================
- Coverage   13.71%   13.49%   -0.22%     
==========================================
  Files         207      207              
  Lines        4646     4720      +74     
  Branches      516      627     +111     
==========================================
  Hits          637      637              
+ Misses       3565     3546      -19     
- Partials      444      537      +93
Impacted Files Coverage Δ
app/react-native/src/bin/storybook-start.js 0% <ø> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <ø> (ø) ⬆️
app/react-native/src/bin/storybook.js 0% <ø> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.93% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
addons/info/src/components/Node.js 0% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
addons/knobs/src/KnobManager.js 38.57% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 0% <0%> (ø) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88a6fa9...08318b0. Read the comment docs.

@shilman shilman closed this Jun 15, 2017
@shilman
Copy link
Member Author

shilman commented Jun 15, 2017

Starting over

@Hypnosphi Hypnosphi deleted the 1220-cra-kitchensink-only branch October 11, 2017 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants