Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create "kitchen sink" sample app #1220

Closed
8 of 9 tasks
shilman opened this issue Jun 8, 2017 · 1 comment
Closed
8 of 9 tasks

Create "kitchen sink" sample app #1220

shilman opened this issue Jun 8, 2017 · 1 comment
Assignees
@shilman

Comments

@shilman
Copy link
Member

shilman commented Jun 8, 2017 •
edited
Loading

why

We should:

  1. have a live example in the repo for documentation purposes
  2. have an example on which to discuss V2 API changes Addon API: proposal #1212
  3. improve our test coverage for "core" addons (how??)

what

Modify examples/test-cra to use all core addons with realistic use cases:

  • actions
  • centered
  • events
  • graphql
  • info
  • knobs
  • links
  • notes
  • options
@shilman shilman self-assigned this Jun 8, 2017
This was referenced Jun 8, 2017
Closed
Merged
Closed
Closed
Merged
@shilman
Copy link
Member Author

shilman commented Jun 15, 2017

Good enough for now 😉

@shilman shilman closed this as completed Jun 15, 2017
@dependencies dependencies bot mentioned this issue Nov 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shilman shilman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shilman