Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VUnit checking #69

Merged
merged 5 commits into from
Jun 11, 2021
Merged

VUnit checking #69

merged 5 commits into from
Jun 11, 2021

Conversation

umarcor
Copy link
Collaborator

@umarcor umarcor commented Jun 11, 2021

In this PR, the Processor workflow is split in two jobs. The main reason is running the VUnit tests and the shell script tests in parallel. Moreover, the installation of the RISC-V toolchain in the VUnit job might be enhanced in the future by using a container.

Other than that, as done with the main testbench, uart_rx is copied to uart_rx.simple.vhd, and it is reverted to the version before self-checking was in place. Other sources/references are updated accordingly. In upcoming PRs, uart_rx will be modified for using VUnit features, while uart_rx_simple will be used for the simple testbench.

Last, one of the enhancements from #48 was cherry-picked here. That uses VUnit's features in uart_rx.

/cc @LarsAsplund

umarcor and others added 5 commits June 11, 2021 16:11
… and checking

Using basic VUnit logging and checking provides (in this case):

* Simpler calls for common assertions like checking equality.
* Color coded logs that makes it easier to spot log entries with different severity levels
@stnolting
Copy link
Owner

Awesome! You even updated the RISC-V architecture test! 🤩👍

@stnolting stnolting merged commit 89bcb20 into stnolting:master Jun 11, 2021
@umarcor
Copy link
Collaborator Author

umarcor commented Jun 11, 2021

In fact... it was done by @LarsAsplund 😆 That was a leftover from #47...

@umarcor umarcor deleted the vunit-checking branch June 11, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants